Thread (10 messages) 10 messages, 7 authors, 2008-01-30

Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping

From: Andy Fleming <hidden>
Date: 2008-01-21 20:05:43

On Jan 3, 2008, at 17:36, Nate Case wrote:
PHY read/write functions can potentially sleep (e.g., a PHY accessed
via I2C).  The following changes were made to account for this:

    * Change spin locks to mutex locks
    * Add a BUG_ON() to phy_read() phy_write() to warn against
      calling them from an interrupt context.
    * Use work queue for PHY state machine handling since
      it can potentially sleep
    * Change phydev lock from spinlock to mutex

Signed-off-by: Nate Case <redacted>

Ok, I've tested this on my system and it works.

Acked-by: Andy Fleming <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help