Thread (2 messages) 2 messages, 2 authors, 2008-01-11

Re: [PATCH] bluetooth : rfcomm tty BUG_ON() code fix

flat view

From: David Miller <davem@davemloft.net>
Date: 2008-01-11 06:23:32
Also in: linux-bluetooth, lkml

From: Dave Young <redacted>
Date: Mon, 7 Jan 2008 13:41:22 +0800
1) In tty.c the BUG_ON at line 115 will never be called, because the the before list_del_init in this same function.
 115          BUG_ON(!list_empty(&dev->list));
So move the list_del_init to rfcomm_dev_del 

2) The rfcomm_dev_del could be called from diffrent path (rfcomm_tty_hangup/rfcomm_dev_state_change/rfcomm_release_dev),
So add another BUG_ON when the rfcomm_dev_del is called more than one time.

Signed-off-by: Dave Young <redacted> 
Applied, thanks Dave.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help