Thread (6 messages) 6 messages, 3 authors, 2007-12-29

Re: [PATCH] Make FC, FDDI, HIPPI and TR tristate

From: Adrian Bunk <bunk@kernel.org>
Date: 2007-12-29 00:52:20

On Sat, Dec 29, 2007 at 01:41:23AM +0100, Jan Engelhardt wrote:
On Dec 29 2007 02:09, Adrian Bunk wrote:
quoted
On Sat, Dec 29, 2007 at 12:45:12AM +0100, Jan Engelhardt wrote:
quoted
Turn CONFIG_FC, CONFIG_FDDI, CONFIG_HIPPI and CONFIG_TR into tristate
so they can be built as modules. This will allow CONFIG_LLC to be
built as a module too, overall reducing the core kernel image size.
...
Just an example of code you have to fix if you do this:

$ grep -r "#ifdef CONFIG_TR" net/
Ah, thank you for reminding me. For lec.c, would it be ok to do

#if defined(CONFIG_TR) || defined(CONFIG_TR_MODULE)
#	define WITH_TR 1
#endif
...
#if defined(CONFIG_TR) || (defined(CONFIG_TR_MODULE) && defined(MODULE))

Otherwise stuff like calling alloc_trdev() will cause build errors with 
CONFIG_TR=m, CONFIG_ATM_LANE=y.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help