Re: [PATCH] TUNTAP: Fix wrong debug message
From: David Miller <davem@davemloft.net>
Date: 2007-12-25 05:30:59
Possibly related (same subject, not in this thread)
- 2007-12-25 · [PATCH] TUNTAP: Fix wrong debug message · Toyo Abe <hidden>
From: Toyo Abe <redacted> Date: Tue, 25 Dec 2007 12:27:56 +0900 (JST)
quoted hunk ↗ jump to hunk
--- Original Messsage ---From: Joe Perches <joe@perches.com> Subject: Re: [PATCH] TUNTAP: Fix wrong debug message Date: Mon, 24 Dec 2007 18:48:48 -0800 Message-ID: <1198550928.19504.1.camel@localhost>quoted
More readable to reverse the strings tun->dev->name, arg ? "enabled" : "disabled");Hello Joe, Thanks for your advice. This is the more readable version.
Applied, thanks Toyo. Joe, please don't provide patch feedback in private emails as it appears you did here. When you do this, it cheapens the value of the feedback because other people reading the list cannot benefit nor comment on it. You've done this to me in the past too, and I told you back then to please stop doing it. Thanks.