Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change
From: David Shwatrz <hidden>
Date: 2007-12-23 13:04:38
Hello,
You should iterate all of ifa_list (for IPv4) / addr_list (for IPv6). For IPv6, we also have anycast (maintained by ac_list) as well.
I am not sure that we need to iterate all of ifa_list in IPv4. The reason is that we end with arp_send, and it initiates a broadcast. So all neighbours will receive it and update their arp tables accordingly. The dest hw in the arp_send is NULL according to this patch ; this means that we will assign dev->broadcast to dest_hw in apr_create(). It seems to me there's no reason to send more than one broadcast. In IPv6, I need to check, since it is multicast. Thoughts ? Regards, DS On Dec 23, 2007 2:38 PM, YOSHIFUJI Hideaki / 吉藤英明 [off-list ref] wrote:
In article [ref] (at Sun, 23 Dec 2007 14:24:00 +0200), "David Shwatrz" [off-list ref] says:quoted
Regarding your answer; I accept it and I will soon send a revised version of this patch (making changes to arp_netdev_event() and ndisc_netdev_event().) I had IPv4 in mind, there is no reason that it will no be also in IPv6.You should iterate all of ifa_list (for IPv4) / addr_list (for IPv6). For IPv6, we also have anycast (maintained by ac_list) as well. --yoshfuji