Re: [PATCH 7/8] Add Wireless Extensions to rndis_host
From: David Brownell <hidden>
Date: 2007-12-23 01:27:32
Also in:
linux-wireless
From: Bjorge Dijkstra <redacted> Subject: [PATCH 7/8] Add Wireless Extensions to rndis_host Date: Sat, 22 Dec 2007 22:51:33 +0100 The bulk of this patch is the addition of a new file that implements the wireless extensions for RNDIS devices. The rest are some smaller changes to usbnet and rndis_host to hook the wireless extensions into them: * a private data pointer is added to usbnet. * a callback is added to driver_info to signal link state changes. * a physical medium type check is added to rndis_bind to check for wireless lan devices and turn on the wireless extensions. * and finally a Kconfig option to enable/disable this all. Signed-off-by: Jussi Kivilinna <redacted> Signed-off-by: Bjorge Dijkstra <redacted>
I'm basically fine with this, but I'll hold off any ack until the issue with the preceding patch (6/8) is resolved. That would boil down to making this a standalone module, or knowing why that's not such a good idea. I'd prefer to see the usbnet core extension packaged separately instead of buried in this patch. :) And I think a MAINTAINERS update for rndis_wext would be appropriate. No way can I take care of that code! (In fact, would you feel comfortable taking over rndis_host too?) - Dave
--- drivers/net/usb/Kconfig | 7 + drivers/net/usb/Makefile | 4 + drivers/net/usb/rndis_base.c | 50 +- drivers/net/usb/rndis_host.h | 18 + drivers/net/usb/rndis_wext.c | 2177 ++++++++++++++++++++++++++++++++++++++++++ drivers/net/usb/usbnet.h | 4 + 6 files changed, 2255 insertions(+), 5 deletions(-) create mode 100644 drivers/net/usb/rndis_wext.c