Thread (1 message) 1 message, 1 author, 2007-12-17

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

From: David Miller <hidden>
Date: 2007-12-17 20:07:48
Also in: linux-wireless

From: "John W. Linville" <redacted>
Date: Mon, 17 Dec 2007 14:34:02 -0500
On Sat, Dec 15, 2007 at 11:31:48PM -0500, John W. Linville wrote:
quoted
Cyrill Gorcunov (2):
      ieee80211_rate: missed unlock
quoted
 net/mac80211/ieee80211_rate.c                  |    1 +
quoted
diff --git a/net/mac80211/ieee80211_rate.c b/net/mac80211/ieee80211_rate.c
index 7254bd6..3260a4a 100644
--- a/net/mac80211/ieee80211_rate.c
+++ b/net/mac80211/ieee80211_rate.c
@@ -33,6 +33,7 @@ int ieee80211_rate_control_register(struct rate_control_ops *ops)
 		if (!strcmp(alg->ops->name, ops->name)) {
 			/* don't register an algorithm twice */
 			WARN_ON(1);
+			mutex_unlock(&rate_ctrl_mutex);
 			return -EALREADY;
 		}
 	}
Crud...there is a one-line fix in here that should have gone to Dave.

Jeff, (assuming Dave ACKs it) would you mind just taking it your
way along with the other posted patches?  Since this is intended for
2.6.24, there should be no great maintenance hardship if it goes to
Linus through your tree instead of Dave's.
It's totally fine if Jeff takes this, don't worry so much about
it :-)

And yes the change looks fine to me too :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help