Re: 2.6.24-rc6-mm1
From: Torsten Kaiser <hidden>
Date: 2007-12-30 21:35:21
Also in:
lkml
On Dec 30, 2007 10:24 PM, J. Bruce Fields [off-list ref] wrote:
On Fri, Dec 28, 2007 at 03:07:46PM -0800, Andrew Morton wrote:quoted
On Fri, 28 Dec 2007 23:53:49 +0100 "Torsten Kaiser" [off-list ref] wrote:quoted
On Dec 23, 2007 5:27 PM, Torsten Kaiser [off-list ref] wrote:quoted
On Dec 23, 2007 8:30 AM, Andrew Morton [off-list ref] wrote:quoted
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/I have finally given up on using 2.6.24-rc3-mm2 with slub_debug=FZP to get more information out of the random crashes I had seen with that version. (Did not crash once with slub_debug, so no new information on what the cause was)Murphy: Just after sending that mail the system crashed two times with slub_debug=FZP, but did not show any new informations. No debug output from slub, only this stacktrace: (Its the same I already reported in the 2.6.24-rc3-mm2 thread)
[snip]
quoted
quoted
[ 7620.708561] Pid: 5698, comm: nfsv4-svc Not tainted 2.6.24-rc3-mm2 #2
[snip]
quoted
That looks like a sunrpc bug. git-nfsd has bene mucking around in there a bit.Can you still reproduce this? Tom thought there was a chance the following could fix it.
Please see also http://lkml.org/lkml/2007/12/29/76 Just wanted to say that slub_debug did not help to get more infos. I will try to reproduce this with rc3-mm2 and the below patch tomorrow. Without slub_debug this seemed to trigger rather reliable when trying to update/upgrade packages on my system.
quoted hunk ↗ jump to hunk
From: Tom Tucker <redacted> Date: Sun, 30 Dec 2007 10:07:17 -0600 Bruce/Aime: Here is what I believe to be the fix for the crashes/svc_xprt BUG_ON that people are seeing. It would be great if those who have seen this problem could apply this patch and see if it resolves their problem. The common code calls svc_xprt_received on behalf of the transport. Since the provider was calling it as well, this resulted in clearing the busy bit/resetting xpt_pool when the BUSY bit wasn't held.diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 4628881..4d39db1 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c@@ -1272,7 +1272,6 @@ static struct svc_xprt *svc_create_socket(struct svc_serv *serv, if ((svsk = svc_setup_socket(serv, sock, &error, flags)) != NULL) { svc_xprt_set_local(&svsk->sk_xprt, newsin, newlen); - svc_xprt_received(&svsk->sk_xprt); return (struct svc_xprt *)svsk; }
I will send a mail, when I'm done with testing this... Thanks for the patch. Torsten