Thread (15 messages) 15 messages, 5 authors, 2007-11-24

Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-11-21 19:53:30
Also in: linuxppc-dev

On Wed, 2007-11-21 at 16:41 +0100, Christoph Hellwig wrote:
On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote:
quoted
It's a bad idea to call flush_scheduled_work from within a
netdev->stop because the linkwatch will occasionally take the
rtnl lock from a workqueue context, and thus that can deadlock.

This reworks things a bit in that area to avoid the problem.
So from the name of the driver you want to keep the previous emac
driver around.  Is there a good reason for that?
Until arch/ppc is gone... the previous driver works with arch/ppc the
new one with arch/powerpc.

If we kill arch/ppc in .25, then we'll remove the old driver and rename
the new one. If not, that will wait til .26

I'm hard at work porting as much of 4xx over I can to get to the point
where we -can- kill arch/ppc but I'm not done yet.

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help