Re: [PATCH] sungem: fix napi regression with reset work
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-11-27 23:31:24
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-11-27 23:31:24
On Mon, 2007-11-26 at 21:02 +0100, Johannes Berg wrote:
sungem's gem_reset_task() will unconditionally try to disable NAPI even when it's called while the interface is not operating and hence the NAPI struct isn't enabled. Make napi_disable() depend on gp->running. Also removes a superfluous test of gp->running in the same function. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> --- Not exactly sure how I got there but I did get stuck in there (sysrq-W) when I plugged in the network cable and booted the computer on the other end of it... while the interface was down. I would've thought that the driver wouldn't even notice the fact that I plugged in the cable while the interface is down, but maybe it does. Or it sets up the device wrongly at resume time when the interface was down at suspend. In any case, this should fix the issue.
Thanks. Ben.