Thread (36 messages) 36 messages, 9 authors, 2007-11-29

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

From: Andi Kleen <hidden>
Date: 2007-11-17 13:18:48

Wang Chen [off-list ref] writes:
Herbert Xu said the following on 2007-11-16 12:11:
quoted
Wang Chen [off-list ref] wrote:
quoted
So, I think the checksum in udp_queue_rcv_skb() actually does
the work, not that in udp_recvmsg() and udp_poll().

If I am wrong, please point out.
We may have a bug in the accounting area.  Check the recent
patch made to UDP/IPv6 which is probably needed here as well.
Like dave said, decrementing the InDataGrams in this case is an
option.
I will check the same place of UDP/IPv6.
And like Benny pointed out it's probably a bad idea because
decrementing counters will be an unexpected ABI change for monitoring 
programs who have no other way to detect overflow.

-Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help