Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
From: Christoph Hellwig <hch@infradead.org>
Date: 2007-11-28 07:44:44
Also in:
linux-scsi, lkml
From: Christoph Hellwig <hch@infradead.org>
Date: 2007-11-28 07:44:44
Also in:
linux-scsi, lkml
I just did a very quick glance over the tree. Some extremly highlevel comments to start with before actually starting the source review: - why do you need your own libcrc? lib/crc32.c has a crc32_le - libsa should go. Much of it is just wrappers of kernel functions that should be used directly. Other like that hash, even or state helpers might either be opencoded in the caller or made completely generic in lib/. Probably the former but we'll have to see.