Thread (5 messages) flat view 5 messages, 2 authors, 2007-10-16

Re: Resend: [IPROUTE2 PATCH] Interface group as new ip link option

From: Laszlo Attila Toth <hidden>
Date: 2007-10-16 11:47:21
Also in: netfilter-devel

jamal írta:
On Tue, 2007-16-10 at 13:05 +0200, Laszlo Attila Toth wrote:
quoted
That sounds great but for what whould you like to use? It may help me 
for the implementation.
For example i may want to add a tc rule to a group of interfaces.
tc BNF roughly looks like:
tc <object> <operation> <target>

Where targe is := <dev devname>
It may be useful to extend "target" to include alternatively a group of
devices.
Ok, I see.
quoted
Currently it is not available since the the 
net_device structure holds the group id and for this get operation an 
iteration (of net_devices) may be necessary...
I understand - but i would rather do the iteration in the kernel than in
user space and save myself a gazillion netlink messages.
You are right - that's faster in the kernel and useless to move it to 
userspace.
quoted
We didn't want to use multiple groups in favour of masked group ids. 
What kind of usage needs other implementation?
Same lazyperson use cases as above; in one case i may want to set a rule
to group = {eth0, eth1, eth10} and in another {eth0,eth5}. I realize
this may be more involved something clever for an implementation (eg
using a bitmap instead of a straight int) - so if it not a simple thing,
just defer it to some later time.
Hm, the main problem (for me) is that it requires more then one value 
per net device and it should be limited. But if I say it is 5 for 
instance, anyone can say it is not enough for him.

Ok, now that you are asking, heres another one feature request for
you;-> It would be nice if i can set a group based on a regular
expression of a devices name; eg "ppp*". Use case for this, off top of
my head (without looking at your syntax):

ip set group 10 ppp*
ip link set ppp0 group 10
also if "ip link set..." works for multiple interfaces it is already 
done. If it is not, it will affect positively all other settings :)

-- 
Attila
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help