Thread (78 messages) flat view 78 messages, 8 authors, 2007-11-26

Re: [PATCH 5/10] [NET]: Avoid unnecessary cloning for ingress filtering

From: Alexey Kuznetsov <hidden>
Date: 2007-10-15 14:56:07

Hello!
If it is causing trouble, then one idea would be to move the resetting
to a wrapper function which calls clone first and then resets the other
fields. All actions currently cloning would need to be mod-ed to use
that call.
I see not so many places inside net/sched/act* where skb_clone is used.
Exactly one in act_mirred.c, to be more exact. Did I miss something?

If you mean that place, your suggestion is correct and everything is OK.

But if there is at least one place where an external skb_clone()
should do this... this cannot be correct. Tell me, it does not matter
what some random skb_clone() makes with tc_verd, please. :-)

Alexey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help