On Thursday 04 October 2007 11:19, John W. Linville wrote:
quoted
The reason why BUG_ON exists is to catch bugs that happen, although
they Should Never Happen (tm) ;)
Precisely.
No really, this bug will never happen. This is function is merely a helper
function which is called from interface removal code (where the interface
*has* to be down) or from changing the interface type (which ensures that the
interface is down first). There are an unlimited number of bugs which Should
Never Happen. That doesn't mean we should start adding BUG_ONs for every
single one of them. That gives some sort of protection against cosmic rays
flipping bits, but down here on earth, it's bloat.
-Michael Wu