Re: Please pull 'z1211' branch of wireless-2.6
From: Michael Buesch <hidden>
Date: 2007-09-22 12:11:11
Also in:
linux-wireless
On Saturday 22 September 2007 11:48:00 Ulrich Kunitz wrote:
A real high-quality driver will require Johannes' proposed mac80211 driver interface changes to be merged and TX confirmations handled in a way, that the semantics can really be supported by the driver. (Michael Buesh's patch is taping over the issue.)
No it is not. It is fixing the issue. It fixes the following issues: * You must ignore the Txstat-requested bit in the driver. * You must report bad frames with the excessive_retries set. The issue you are (most likely) talking about is that we can not reliably tell whether a frame was good in the driver. That is a different issue completely seperate from the two points above, which my patch fixes. With my patch rate-controlling correctly works. Without it does not. If you find a way to fix the reliable-detection-of-good-TX issue, that's another good fix. But I think it's not release critical, because the device works with the current "guessing-around" code. But without the two points above fixed, it does not correctly work at all (unless you manually tune to the best rate each time you move the machine). -- Greetings Michael.