Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit
From: David Miller <davem@davemloft.net>
Date: 2007-09-19 23:12:17
Possibly related (same subject, not in this thread)
- 2007-09-18 · [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit · Herbert Xu <herbert@gondor.apana.org.au>
From: Adrian Bunk <bunk@kernel.org> Date: Thu, 20 Sep 2007 01:11:14 +0200
On Wed, Sep 19, 2007 at 10:45:13AM -0700, David Miller wrote:quoted
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Wed, 19 Sep 2007 09:30:18 +0800quoted
[PPP] pppoe: Fix double-free on skb after transmit failure When I got rid of the second packet in __pppoe_xmit I created a double-free on the skb because of the goto abort on failure. This patch removes that. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>Applied.Please excuse in case this was already clear, but since this regression made it into Linus' tree it should be fixed there before 2.6.23.
I will make sure this happens. I'm just waiting for Alexey to test the SFQ crash fix and then I'll send everything queued.