Thread (8 messages) flat view 8 messages, 3 authors, 2007-09-13

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

From: David Miller <davem@davemloft.net>
Date: 2007-09-12 13:32:14

From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 12 Sep 2007 07:19:56 -0600
I was getting strange kernel crashes when attempting to
create veth devices when I did not specify a peer argument
to /bin/ip.

So this patch defaults peer_tb to all zeros and doesn't attempt to
reuse the netlink attributes for the primary link to create the
secondary link and now I can't reproduce the failures.

Given that some of the most interesting netlink attributes to specify
like a mac address or a network device name seem are generally
the wrong thing to do this seems like the right approach.

Signed-off-by: Eric W. Biederman <redacted>
This looks mostly fine, can someone else who knows
veth a bit review this as well?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help