Re: [PATCH 03/16] net: Basic network namespace infrastructure.

From
Krishna Kumar2 <hidden>
Date
2007-09-10 05:46:10
Reply to
Eric W. Biederman, 2007-09-08
Eric W. Biederman wrote on 09/09/2007 02:45:34 AM:

Hi Eric,
+static int register_pernet_operations(struct list_head *list,
+                  struct pernet_operations *ops)
+{
<snip>
+out:
+   return error;
+
+out_undo:
+   /* If I have an error cleanup all namespaces I initialized */
+   list_del(&ops->list);
+   for_each_net(undo_net) {
+      if (undo_net == net)
+         goto undone;
+      if (ops->exit)
+         ops->exit(undo_net);
+   }
+undone:
+   goto out;
+}
You could remove "undone" label (and associated) goto with a "break".
quoted hunk ↗ jump to hunk
+static void unregister_pernet_operations(struct pernet_operations *ops)
+{
+   struct net *net;
+
+   list_del(&ops->list);
+   for_each_net(net)
+      if (ops->exit)
+         ops->exit(net);
+}
+
+/**
+ *      register_pernet_subsys - register a network namespace subsystem
+ *   @ops:  pernet operations structure for the subsystem
+ *
+ *   Register a subsystem which has init and exit functions
+ *   that are called when network namespaces are created and
+ *   destroyed respectively.
+ *
+ *   When registered all network namespace init functions are
+ *   called for every existing network namespace.  Allowing kernel
+ *   modules to have a race free view of the set of network namespaces.
+ *
+ *   When a new network namespace is created all of the init
+ *   methods are called in the order in which they were registered.
+ *
+ *   When a network namespace is destroyed all of the exit methods
+ *   are called in the reverse of the order with which they were
+ *   registered.
+ */
<snip>
+/**
+ *      unregister_pernet_subsys - unregister a network namespace
subsystem
quoted hunk ↗ jump to hunk
+ *   @ops: pernet operations structure to manipulate
+ *
+ *   Remove the pernet operations structure from the list to be
+ *   used when network namespaces are created or destoryed.  In
+ *   addition run the exit method for all existing network
+ *   namespaces.
+ */
+void unregister_pernet_subsys(struct pernet_operations *module)
+{
+   mutex_lock(&net_mutex);
+   unregister_pernet_operations(module);
+   mutex_unlock(&net_mutex);
+}
Don't you require something like for_each_net_backwards to 'exit' in
reverse order? Same comment for unregister_subnet_subsys(). Should this
be done for failure in register_pernet_operations too?

thanks,

- KK
Thread (42 messages) 42 messages, 6 authors, last reply 2007-09-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help