Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

Maciej W. Rozycki wrote:

On Thu, 20 Sep 2007, Jeff Garzik wrote:

quoted

quoted

You may be pleased (or less so) to hear that the version of sb1250-mac.c in
your tree does not even build (because of
42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not
address it.  I ran out of time in the evening, but I will send you a fix
shortly.  To be honest I think even with bulk changes it may be worth
checking whether they do not break stuff. ;-)

hrm.  I cannot get this to apply on top of linux-2.6.git,
netdev-2.6.git#upstream (prior to net-2.6.24 rebase) or
netdev-2.6.git#upstream (after net-2.6.24 rebase)

 It applies on top of current -mm.  It seems to apply to a copy of 
netdev-2.6.git#upstream that I have got, but I am probably missing 
something...  If I try to clone your repository again I get:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/linux-netdev-2.6.git linux
Initialized empty Git repository in /home/macro/GIT-other/linux-netdev/linux/.git/
fatal: The remote end hung up unexpectedly
fetch-pack from 'git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/linux-netdev-2.6.git' failed.

Remove the "linux-" prefix.

	Jeff