Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

On Tue, Sep 04, 2007 at 02:09:47PM +0530, Satyam Sharma wrote:

Hi Steffen,


On Tue, 4 Sep 2007, Steffen Klassert wrote:

quoted

On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote:

quoted

drivers/net/3c59x.c: In function 'vortex_up':
drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in this function

This came in with the recently applied 3c59x-check-return-of-pci_enable_device patch
from Mark Hindley. I just compiled it on a PCI only machine so far, therefore I did
not notice the warning yet.

Hmm, the .config I built with had PCI=y as well. Probably a compiler
version difference -- Jeff also mentioned yesterday that some newer
GCC versions fail to warn about uninitialized variables cases.

Sorry, this is my bad. I have just checked: there is no warning with gcc
4.2 or 4.1, but 3.3 emits the warning. 

quoted

quoted

is a genuine bug. The function returns an uninitialized value of 'err'
back to the caller, which expects it to be 0 for success cases. Let's
fix this by explicitly initializing 'err' to zero.

Signed-off-by: Satyam Sharma <redacted>

Acked-by: Steffen Klassert <redacted>

Acked-by: Mark Hindley <redacted>