Re: [PATCH] Don't needlessly initialize variable to NULL in zd_chip (was: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver)
From: Randy Dunlap <hidden>
Date: 2007-08-30 22:50:25
Also in:
linux-wireless, lkml
On Fri, 31 Aug 2007 00:30:31 +0200 Jesper Juhl wrote:
On Friday 31 August 2007 00:19:53 Joe Perches wrote:quoted
On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote:quoted
Ok, I must admit I didn't check with sparse since it seemed pointless - we usually never cast void pointers to other pointer types, specifically because the C language nicely guarantees that the right thing will happen without the cast. Sometimes we have to cast them to integer types, su sure we need the cast there. But what on earth makes a "zd_addr_t *" so special that we have to explicitly cast a "void *" to that type?http://marc.info/?l=linux-netdev&m=117113743902549&w=1Thank you for that link Joe. I'm not sure I agree with the __nocast, but I respect that this is the maintainers choice. But, I still think the first chunk of the patch that removes the initial variable initialization makes sense. Initializing the variable to NULL is pointless since it'll never be used before the kmalloc() call. So here's a revised patch that just gets rid of that little detail.
BTW: http://marc.info/?l=linux-wireless&m=118831813500769&w=2
quoted hunk ↗ jump to hunk
No need to initialize to NULL when variable is never used before it's assigned the return value of a kmalloc() call. Signed-off-by: Jesper Juhl <redacted> ---diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c index c39f198..30872fe 100644 --- a/drivers/net/wireless/zd1211rw/zd_chip.c +++ b/drivers/net/wireless/zd1211rw/zd_chip.c@@ -106,7 +106,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr { int r; int i; - zd_addr_t *a16 = (zd_addr_t *)NULL; + zd_addr_t *a16; u16 *v16; unsigned int count16;
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***