Re: [PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes
From: Stephen Rothwell <hidden>
Date: 2007-08-23 00:31:09
Also in:
linuxppc-dev
Hi Olof, On Wed, 22 Aug 2007 09:12:48 -0500 Olof Johansson [off-list ref] wrote:
-static unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int reg) +static inline unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int reg)
^^^^^^ For static functions in C files, we tend not to bother marking them inline any more as the compiler does a pretty good job theses days.
{
unsigned int val;
- pci_read_config_dword(mac->iob_pdev, reg, &val);
+ val = in_le32(mac->iob_regs+reg);
+
return val;Why not just "return in_le32(mac->iob_regs+reg);" ? And similarly below?
+static inline void __iomem * __devinit map_onedev(struct pci_dev *p, int index)
^^^^^^ ^^^^^^^^^ Mixing inline and __*init is just plain silly :-)
+fallback: + /* This is hardcoded and ugly, but we have some firmware versions + * who don't provide the register space in the device tree. Luckily
^^^ "that" -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Attachments
- (unnamed) [application/pgp-signature] 189 bytes