Re: [PATCH 1/3] netxen: Avoid firmware load in PCI probe
From: Arnaldo Carvalho de Melo <hidden>
Date: 2007-08-30 21:58:45
Em Tue, Aug 28, 2007 at 05:23:25PM +0530, dhananjay@netxen.com escreveu:
Loading firmware during PCI probe can lead to incorrect initialization, rendering the card unusable until next reboot. This was introduced a while ago as a workaround for firmware bug, a better workaround was submitted for this a while ago. So removing original hack that loads firmware during probe. Signed-off by: Dhananjay Phadke [off-list ref]
Acked-by: Arnaldo Carvalho de Melo <redacted> I was having these problems and after applying this patch the NIC is back working, thank you for fixing this! - Arnaldo
quoted hunk
Index: netdev-2.6/drivers/net/netxen/netxen_nic_main.c ===================================================================--- netdev-2.6.orig/drivers/net/netxen/netxen_nic_main.c +++ netdev-2.6/drivers/net/netxen/netxen_nic_main.c@@ -639,10 +639,6 @@ netxen_nic_probe(struct pci_dev *pdev, c NETXEN_CRB_NORMALIZE(adapter, NETXEN_ROMUSB_GLB_PEGTUNE_DONE)); /* Handshake with the card before we register the devices. */ - writel(0, NETXEN_CRB_NORMALIZE(adapter, CRB_CMDPEG_STATE)); - netxen_pinit_from_rom(adapter, 0); - msleep(1); - netxen_load_firmware(adapter); netxen_phantom_init(adapter, NETXEN_NIC_PEG_TUNE); }