[patch 3/7] qeth: dont return the return values of void functions.
From: Ursula Braun <hidden>
Date: 2007-08-27 17:31:05
Also in:
linux-s390
From: Heiko Carstens <redacted> Signed-off-by: Heiko Carstens <redacted> Signed-off-by: Ursula Braun <redacted> --- drivers/s390/net/qeth.h | 4 ++-- drivers/s390/net/qeth_sys.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) Index: linux-2.6-uschi/drivers/s390/net/qeth.h ===================================================================
--- linux-2.6-uschi.orig/drivers/s390/net/qeth.h
+++ linux-2.6-uschi/drivers/s390/net/qeth.h@@ -1178,9 +1178,9 @@ qeth_ipaddr_to_string(enum qeth_prot_ver char *buf) { if (proto == QETH_PROT_IPV4) - return qeth_ipaddr4_to_string(addr, buf); + qeth_ipaddr4_to_string(addr, buf); else if (proto == QETH_PROT_IPV6) - return qeth_ipaddr6_to_string(addr, buf); + qeth_ipaddr6_to_string(addr, buf); } static inline int
Index: linux-2.6-uschi/drivers/s390/net/qeth_sys.c ===================================================================
--- linux-2.6-uschi.orig/drivers/s390/net/qeth_sys.c
+++ linux-2.6-uschi/drivers/s390/net/qeth_sys.c@@ -1760,10 +1760,10 @@ qeth_remove_device_attributes(struct dev { struct qeth_card *card = dev->driver_data; - if (card->info.type == QETH_CARD_TYPE_OSN) - return sysfs_remove_group(&dev->kobj, - &qeth_osn_device_attr_group); - + if (card->info.type == QETH_CARD_TYPE_OSN) { + sysfs_remove_group(&dev->kobj, &qeth_osn_device_attr_group); + return; + } sysfs_remove_group(&dev->kobj, &qeth_device_attr_group); sysfs_remove_group(&dev->kobj, &qeth_device_ipato_group); sysfs_remove_group(&dev->kobj, &qeth_device_vipa_group);
--