Re: [PATCH 2/4] Net: mac80211, remove bitfields from struct ieee80211_txrx_data

Johannes Berg napsal(a):

On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote:

quoted

-	unsigned int fragmented:1; /* whether the MSDU was fragmented */
+	/* whether the MSDU was fragmented */
+#define IEEE80211_TXRXD_FRAGMENTED		BIT(0)
+#define IEEE80211_TXRXD_TXUNICAST		BIT(1)
+#define IEEE80211_TXRXD_TXPS_BUFFERED		BIT(2)
+#define IEEE80211_TXRXD_TXPROBE_LAST_FRAG	BIT(3)
+#define IEEE80211_TXRXD_RXIN_SCAN		BIT(4)

I know this isn't the style currently used, but could you put these
definitions before the struct declaration? That way, kerneldoc doesn't
totally screw up.

OK

-- 
Jiri Slaby (jirislaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org)
Faculty of Informatics, Masaryk University