Thread (2 messages) flat view 2 messages, 2 authors, 2007-08-10

Re: [patch 14/28] dccp: fix memory leak and clean up style - dccp_feat_empty_confirm()

From: David Miller <davem@davemloft.net>
Date: 2007-08-10 22:24:09

From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:11:57 -0700
From: Jesper Juhl <redacted>

There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm().  If we
hit the 'default:' case of the 'switch' statement, then we return without
freeing 'opt', thus leaking 'struct dccp_opt_pend' bytes.

The leak is fixed easily enough by adding a kfree(opt); before the return
statement.

The patch also changes the layout of the 'switch' to be more in line with
CodingStyle.

Signed-off-by: Jesper Juhl <redacted>
Acked-by: Ian McDonald <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help