Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

On Fri, 10 Aug 2007 17:13:49 -0400
Benjamin LaHaise [off-list ref] wrote:

On Fri, Aug 10, 2007 at 02:05:13PM -0700, akpm@linux-foundation.org wrote:

quoted

Also added a "disable_autoneg" module argument to completely disable
autoneg on all cards using this driver.

...

quoted

[akpm: this is a previously-nacked patch, but the problem is real]

Please remove this part of the patch.  The ethtool support is sufficient and 
doesn't clobber other cards in the system.  At the very least the module 
parameter has to be limited to a specific card.

I think I'll drop the whole patch.  I've been nursing the thing along for
1.5 years and I don't recall seeing any reports of any bugs which it would
have fixed anyway.