Thread (6 messages) 6 messages, 4 authors, 2007-08-01

Re: [PATCH]: Fix sk_buff page offsets and lengths.

From: David Miller <davem@davemloft.net>
Date: 2007-08-01 20:44:09

From: Eric Dumazet <redacted>
Date: Tue, 31 Jul 2007 10:52:15 +0200
I understand ifdefs are ugly, but in the common case
(PAGE_SIZE<64K), this change seems very unfortunate.
If this bothers you so much start where the real problems are and
advocate on linux-kernel for descreasing the type size of "offset" and
"length" in struct scatterlist.  It's a bit on the hypocritical side
to complain about this skb_frag_t change when I've never seen a peep
out of you about scatterlist doing the same thing :-)

Otherwise, we're better off with the types being the same so that we
can use scatterlist in skb_frag_t and therefore kill serious
performance problems with DMA mapping of sk_buff objects that exists
today on platforms such as powerpc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help