Re: [PATCH] Merge the Sonics Silicon Backplane subsystem
From: Michael Buesch <hidden>
Date: 2007-07-27 19:41:45
Also in:
linux-wireless, lkml
From: Michael Buesch <hidden>
Date: 2007-07-27 19:41:45
Also in:
linux-wireless, lkml
On Friday 27 July 2007 21:21:20 John W. Linville wrote:
On Fri, Jul 27, 2007 at 06:57:20PM +0200, Michael Buesch wrote:quoted
The Sonics Silicon Backplane is a mini-bus used on various Broadcom chips and embedded devices. Devices using the SSB include b44, bcm43xx and various Broadcom based wireless routers. A b44 and bcm43xx port and a SSB based OHCI driver is available. Signed-off-by: Michael Buesch <redacted>At first glance it looks like there might be some tab/space issues in some of the #define blocks toward the end of the patch, although those might be intentional.
They are intentional. It's something like this: #define SSB_REGISTER_XX 0xF88 #define SSB_VALUE_FOR_REGISTER_XX 0x0001 #define SSB_MASK_FOR_REGISTER_XX 0xFF00 #define SSB_REGISTER_YY 0xF99 ...
Aside from whatever other style issues that might be identified, I'll state that this code has been carried in wireless-dev for months and thereby also spent a lot of time in -mm as well as Fedora (rawhide and F-7). The code has proven to be reasonably stable and reliable.
And it's in the OpenWRT trunk since quite some time. -- Greetings Michael.