Re: 2.6.23-rc1 sky2 boot crash in sky2_mac_intr

On Wed, 25 Jul 2007 09:22:02 +0200
Florian Lohoff [off-list ref] wrote:

On Wed, Jul 25, 2007 at 01:30:31AM +0200, Michal Piotrowski wrote:

quoted

quoted

I'll try the above and keep you posted. The crash itself seems to be a
2.6.23-rc1 regression though. I never experienced this with 2.6.22-rc5
which i was running before.

Can you try to figure out what is causing this crash and then use 
git-bisect?

Are there so many changes between 2.6.22-rc5 and 2.6.23-rc1 for the sky2?

As the crash is not that reproducible, just occasionally on boot i guess
bisecting is more or less waste of time.

Flo
-- 
Florian Lohoff                  flo@rfc822.org             +49-171-2280134
	Those who would give up a little freedom to get a little 
          security shall soon have neither - Benjamin Franklin

I would suspect these as possible causes of the regression was one of these
patches.

commit 8f70920f2f2a699b4ad35e625071cd92f4ba6ca3
Author: Stephen Hemminger [off-list ref]
Date:   Mon Jun 4 17:23:25 2007 -0700

    sky2: GPIO register
    
    The General Purpose I/O register is yet another hardware workaround
    catchall. Enable workaround that vendor driver does to stay
    but for bug compatiable.
    
    Signed-off-by: Stephen Hemminger [off-list ref]
    Signed-off-by: Jeff Garzik [off-list ref]

commit 451af33552286b426940a32126bd3ece243223a3
Author: Stephen Hemminger [off-list ref]
Date:   Mon Jun 4 17:23:24 2007 -0700

    sky2: enable clocks before probe
    
    Catch-22: On Yukon EX (88E8071) need to have internal clocks enabled
    before reading chip id. It is harmless on other chips.
    
    Signed-off-by: Stephen Hemminger [off-list ref]
    Signed-off-by: Jeff Garzik [off-list ref]

commit fc99fe0618f355b708ce88fedaca9783072ac3d5
Author: Stephen Hemminger [off-list ref]
Date:   Mon Jun 4 17:23:22 2007 -0700

    sky2: Add PCI device specfic register 4 & 5
    
    Need to setup more PCI control control registers are on Yukon EX.
    Some of these also exist on Yukon EC-U as well.
    
    Signed-off-by: Stephen Hemminger [off-list ref]
    Signed-off-by: Jeff Garzik [off-list ref]