Re: [PATCH] IP_VS should depend on EXPERIMENTAL ?

Robert P. J. Day wrote:

On Fri, 20 Jul 2007, Gabriel C wrote:

quoted

Robert P. J. Day wrote:

quoted

On Fri, 20 Jul 2007, Gabriel C wrote:

quoted

Hi,

IP_VS has :

..

tristate "IP virtual server support (EXPERIMENTAL)"

..

but it does not depend on EXPERIMENTAL.


Signed-off-by: Gabriel Craciunescu <redacted>

---

 net/ipv4/ipvs/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/ipvs/Kconfig b/net/ipv4/ipvs/Kconfig
index 09d0c3f..3c594ec 100644
--- a/net/ipv4/ipvs/Kconfig
+++ b/net/ipv4/ipvs/Kconfig

@@ -3,7 +3,7 @@
 #
 menuconfig IP_VS
 	tristate "IP virtual server support (EXPERIMENTAL)"
-	depends on NETFILTER
+	depends on NETFILTER && EXPERIMENTAL
 	---help---
 	  IP Virtual Server support will let you build a high-performance
 	  virtual server based on cluster of two or more real servers. This

there's maturity-level inconsistency like that in a few places, like
when stuff is tagged as EXPERIMENTAL, but labelled as OBSOLETE:

[ a lot examples ]

I know that and there are a lot more things depending on
'EXPERIMENTAL' and not having EXPERIMENTAL visible all over the tree
but that patch I've made for the _net_ part got NACK'ed while your
maturity idea and I rm -rf'ed all the other.

This one has a missing depends on EXPERIMENTAL while saying it is.

So *could* we please stop this maturity stuff for now ? I don't see
it in .23 nor .24 if at all.

this has *nothing* to do with the aforementioned maturity levels.  i
understand entirely the inconsistency above.  what i'm suggesting is
that it might very well be more appropriate to *drop the dependency*
rather than munge the prompt to add the qualifier.

This is a thing the author/maintainer/subsystem maintainer should and need do.

They know when something is not EXPERIMENTAL anymore.

i think it's safe to say that there's *piles* of stuff in the Kconfig
files that is still saddled with an EXPERIMENTAL dependency that's
been around for years and has stabilized nicely.  

I agree with you , there may be a lot things are marked EXPERIMENTAL but aren't anymore.

i mean, seriously,
is IP virtual server support still "experimental" in any way?

rday

Gabriel