Re: [patch 37/44] xen: add virtual network device driver

Stephen Hemminger wrote:

quoted

+struct netfront_info {
+	struct list_head list;
+	struct net_device *netdev;
+
+	struct net_device_stats stats;
    

There is now a net_device_stats element inside net_device on
2.6.21 or later.
  

Ah, OK.  Should I just do a s/stats/netdev->stats/?  Is there a generic
get_stats routine as well?

quoted

+
+	struct xen_netif_tx_front_ring tx;
+	struct xen_netif_rx_front_ring rx;
+
+	spinlock_t   tx_lock;
+	spinlock_t   rx_lock;
    

It might be a performance advantage to reorder/align these
structure elements to put transmit hot elements together, and
put tx and rx on different cache lines?
  

Oh, right.  I'd been meaning to look at that layout more closely.

Thanks,
    J