Thread (13 messages) flat view 13 messages, 5 authors, 2007-07-15

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

From: Jeff Garzik <hidden>
Date: 2007-07-14 20:33:55
Also in: lkml

Michael Buesch wrote:
Well, this bitfield _might_ be OK (although I don't like bitfields
at all), but the above pointer casting stuff should really use
leXX_to_cpu. It's so easy to use and it is easier to read and
maintain the code afterwards.
If the bitfield stays, a comment must be added.
Regardless of endian issues, the bitfield usage should go away.

	Jeff

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help