Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

On Wed, 4 Jul 2007, Joel Becker wrote:

On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:

quoted

-	if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
-		goto done;
+	if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
+	      event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
+	      	goto done;

 	if (nt->np.dev == dev) {
 		switch (event) {

	It's a small nit, but isn't the large if() just the degenerate
default case of the switch()?  Why have it at all?  

Yes, the large if() is redundant in this particular patch.

But in further patches, the switch() is enclosed inside a 
spin_lock_irqsave() and list_for_each_entry(target_list) and so the
large if() upfront saves us from unnecessarily disabling interrupts
and iterating through the entire target_list in the case that it is
a notification for an event that we don't care about.

So I'll remove this if() from this patch and introduce it in the
later one itself, which is where it starts making some sense, anyway.

Satyam