Thread (5 messages) flat view 5 messages, 4 authors, 2007-07-19

Re: [PATCH 1/2] Fix error checking in Vitesse IRQ config

From: Jon Loeliger <hidden>
Date: 2007-07-19 16:49:49
Also in: linuxppc-dev

On Wed, 2007-07-18 at 01:35, Andy Fleming wrote:
quoted hunk ↗ jump to hunk
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero.  Correct that.

Signed-off-by: Andy Fleming <redacted>
---
I made a really stupid mistake in the 4 patches I sent out, earlier.  I
thought those patches had been tested, but they hadn't been.  This one
corrects a tiny error in the patch, and they have now been tested.  As before
this change can be pulled from:

http://opensource.freescale.com/pub/scm/linux-2.6-85xx.git netdev

Really, REALLY sorry about that.  I have been given a paper bag of appropriate
size and shape to fit over my head.

 drivers/net/phy/vitesse.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
index 6a53856..8874497 100644

Acked-by: Jon Loeliger <redacted>

Tested on the 8641HPCN.

Thanks,
jdl

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help