Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support
From: Joakim Koskela <hidden>
Date: 2007-07-31 12:12:10
From: Joakim Koskela <hidden>
Date: 2007-07-31 12:12:10
On Tuesday 31 July 2007 14:14:30 Patrick McHardy wrote:
Joakim Koskela wrote:quoted
Ok, so changing int xfrm[46]_output(struct sk_buff*) to use the right PF & hook based on the skb's [current] family should put things through the right hoops, right?Almost, in xfrm4_output the conditional calling of the hook should only be done for IPv4 and the IPCB is not valid for IPv6 of course. Speaking of which, shouldn't the entire cb be zeroed for interfamily transforms? xfrm4_tunnel_output only clears out the options, and I think your patch didn't touch it at all ..
Right, thanks for pointing out (to my understanding both flags and opts should be reset for 6-4, on 4-4 only the opts)! br ,j