Re: [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows
From: Stephen Hemminger <hidden>
Date: 2007-07-31 09:51:39
From: Stephen Hemminger <hidden>
Date: 2007-07-31 09:51:39
On Mon, 30 Jul 2007 22:21:12 -0700 (PDT) David Miller [off-list ref] wrote:
From: "Ilpo_Järvinen" <redacted> Date: Tue, 31 Jul 2007 07:59:10 +0300 (EEST)quoted
I think it's probably good to add tp->snd_una != prior_snd_una check there too... It's not going to make a large difference, mostly just to be conservative when skb collapse stuff got done (and maybe to annoy cheaters too though I couldn't at this point figure out how they could abuse it)... ...I think I can come up with that on Wednesday, so please hold stable push until that.It'll definitely need to wait at least a day as I cannot even make TCP or UDP connections out from my machine with the current net-2.6 tree, and this is what I'm debugging at the moment. I'm hoping that it's just something stupid like the make not rebuilding everything necessary after I changed the __u16's into __u32's in skb_frag_t.
I running tests over emulator this morning. Hopefully, this will fix the window collapse that occurs on startup of large queue sizes.