Re: [PATCH 2/6] [NET]: Take dev_base_lock when moving device name hash list entry
From: David Miller <davem@davemloft.net>
Date: 2007-07-30 23:36:09
From: David Miller <davem@davemloft.net>
Date: 2007-07-30 23:36:09
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Thu, 26 Jul 2007 17:09:30 +0800
[NET]: Take dev_base_lock when moving device name hash list entry When we added name-based hashing the dev_base_lock was designated as the lock to take when changing the name hash list. Unfortunately, because it was a preexisting lock that just happened to be taken in the right spots we neglected to take it in dev_change_name. The race can affect calles of __dev_get_by_name that do so without taking the RTNL. They may end up walking down the wrong hash chain and end up missing the device that they're looking for. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Good catch, applied, thanks Herbert.