Thread (1 message) 1 message, 1 author, 2007-07-16
DORMANTno replies

[PATCH] mac80211: fix GCC warning on 64bit platforms

From: Jiri Benc <hidden>
Date: 2007-07-16 16:46:53
Also in: linux-wireless

net/mac80211/ieee80211.c: In function ieee80211_register_hw:
net/mac80211/ieee80211.c:4989: warning: comparison of distinct pointer types lacks a cast

Fix by casting from size_t to unsigned as size of ieee80211_tx_status_rtap_hdr
structure will never be greater than that.

Signed-off-by: Jiri Benc <redacted>

---

On Sat, 14 Jul 2007 20:41:16 -0700 (PDT), David Miller wrote:
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Date: Sat, 14 Jul 2007 18:59:35 -0700 (PDT)
quoted
From: "John W. Linville" <redacted>
Date: Thu, 12 Jul 2007 16:41:38 -0400
quoted
This request is based off net-2.6, as it requires a patch that is in
net-2.6 but not yet in Linus' tree (b3d88ad49a0623d09efcf998beb26288c8029f75).
 ...
quoted
  git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-davem
Pulled, thanks John!
A warning to look into:

net/mac80211/ieee80211.c: In function $,1rxieee80211_register_hw$,1ry:
net/mac80211/ieee80211.c:4989: warning: comparison of distinct pointer types lacks a cast
---
 net/mac80211/ieee80211.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- mac80211-2.6.orig/net/mac80211/ieee80211.c
+++ mac80211-2.6/net/mac80211/ieee80211.c
@@ -4987,7 +4987,7 @@ int ieee80211_register_hw(struct ieee802
 	 * interfaces, but never both at the same time.
 	 */
 	local->tx_headroom = max(local->hw.extra_tx_headroom,
-				 sizeof(struct ieee80211_tx_status_rtap_hdr));
+				 (unsigned)sizeof(struct ieee80211_tx_status_rtap_hdr));
 
 	debugfs_hw_add(local);
 
-- 
Jiri Benc
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help