Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2
From: Jeff Garzik <hidden>
Date: 2007-07-03 13:11:14
Masakazu Mokuno wrote:
quoted
quoted
--- a/drivers/net/Makefile +++ b/drivers/net/Makefile@@ -60,6 +60,8 @@ obj-$(CONFIG_TIGON3) += tg3.o obj-$(CONFIG_BNX2) += bnx2.o spidernet-y += spider_net.o spider_net_ethtool.o obj-$(CONFIG_SPIDER_NET) += spidernet.o sungem_phy.o +obj-$(CONFIG_GELIC_NET) += ps3_gelic.o +ps3_gelic-objs += gelic_net.o obj-$(CONFIG_TC35815) += tc35815.o obj-$(CONFIG_SKGE) += skge.o obj-$(CONFIG_SKY2) += sky2.o --- /dev/null +++ b/drivers/net/gelic_net.cThe patch does not reflect the new name...The driver's module name is 'ps3_gelic.ko' and the souce file names are 'gelic_net.{c,h}'. As Geoff Levand said in the mail dated June 16, we have plan to add wireless support and its file name would be gelic_wireless.c. If this support added, the make file would be: obj-$(CONFIG_GELIC_NET) += ps3_gelic.o gelic-$(CONFIG_GELIC_WIRELESS) += gelic_wireless.o ps3_gelic-objs += gelic_net.o $(gelic-y)
For single-file modules, the source file prefix should match the output file prefix. No Linux driver does it any other way. It leads to confusion. Jeff