Jeff Garzik [off-list ref] :

Arjan van de Ven wrote:

quoted

quoted

+	pci_write_config_byte(tp->pci_dev, PCI_LATENCY_TIMER, 0x40);

can you create a pci_set_latency_timer() for this please?

[...]

quoted

quoted

+	if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
+		pci_write_config_byte(tp->pci_dev, PCI_CACHE_LINE_SIZE, 
0x08);

and something for this as well?

Why?  Nothing here seems generic to me.

I.e. no need for pci_set_latency_timer(struct pci_dev *dev, u8 latency)
neither pci_set_cache_line_size(struct pci_dev *dev, u8 size) ?

-- 
Ueimor