Re: [Bugme-new] [Bug 8668] New: HTB Deadlock
From: Jarek Poplawski <hidden>
Date: 2007-06-27 12:02:04
On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:quoted
On 25-06-2007 11:28, Patrick McHardy wrote: ...quoted
It is. This patch I had originally planned for 2.6.23 switches HTB to the generic estimator, which shouldn't suffer from this.BTW, maybe I look at this too short, but is this del_timer() in gen_kill_estimator() enough? I cannot see nothing against a timer just running and doing mod_timer() again...Yes, but nothing bad can happen, the timer will find an empty list and do nothing. It would make more sense to check for an empty list before restarting the timer though. Could you send a patch for that?
Probably I could, but it's your idea! I look at this just now, and maybe it's enough for asking, but definitely not enough for patch. I'll try to check this more in the evening, so I could send something tomorrow. So if it's not only about kindness, feel free to do it sooner and I've no doubts - better. Thanks for so instant reply! Jarek P.