Thread (2 messages) 2 messages, 2 authors, 2007-06-27

Re: [PATCH] netpoll: tx lock deadlock fix

From: David Miller <davem@davemloft.net>
Date: 2007-06-27 07:40:09

From: Stephen Hemminger <redacted>
Date: Tue, 29 May 2007 17:32:21 -0700
If sky2 device poll routine is called from netpoll_send_skb, it
would deadlock. The netpoll_send_skb held the netif_tx_lock, and the
poll routine could acquire it to clean up skb's. Other drivers
might use same locking model.

The driver is correct, netpoll should not introduce more locking problems
than it causes already. So change the code to drop lock before calling
poll handler.

Signed-off-by: Stephen Hemminger <redacted>
Patch applied, thanks Stephen.

Once I get this to Linus would you like me to toss it over
to the -stable folks too?

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help