Re: [PATCH 2.6.21.1] ipconfig: add support for multiple user devs
From: David Miller <davem@davemloft.net>
Date: 2007-06-27 06:52:05
From: David Miller <davem@davemloft.net>
Date: 2007-06-27 06:52:05
From: "Sean Kormilo" <redacted> Date: Thu, 17 May 2007 15:16:12 -0400
Update ipconfig to enable users to specify multiple devices on the kernel commandline ip= option. This allows for up-to 4 devices to be specified, with devices separated by a '/' character. For example, to limit autoconfig requests to eth0 and eth2: ip=:::::eth0/eth2:DHCP This is required in cases where one might want to allow DHCP requests from multiple devices, but not necessarily want to broadcast on all ethernet devices that are present in the system.
Hi Sean. I have no objections to your patch, except that the 4 device limit seems arbitrary. I would suggest to dynamically kmalloc() up a string buffer after parsing the option string counting the "/" characters present. That way there is no limit to the number of devices which can be specified. Please make this change and resubmit your patch so that I can include it, thanks!