Thread (2 messages) 2 messages, 2 authors, 2007-06-26

Re: [PATCH UPDATE] Ethernet driver for EISA only SNI RM200/RM400 machines

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2007-06-26 22:05:48

Thomas Bogendoerfer [off-list ref] :
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/sni_82596.c b/drivers/net/sni_82596.c
new file mode 100644
index 0000000..80e32ad
--- /dev/null
+++ b/drivers/net/sni_82596.c
[...]
+static int __devinit sni_82596_probe(struct platform_device *dev)
+{
[...]
+	if (retval) {
+		free_netdev(netdevice);
+probe_failed:
+		if (mpu_addr)
+			iounmap(mpu_addr);
+		if (ca_addr)
+			iounmap(ca_addr);
+		if (eth_addr)
                    ^^^
+			iounmap(ca_addr);
                                ^^
-> typo

Please use plain goto with proper labels and remove the tests.

-- 
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help