Re: [NET] au1000_eth: Fix warnings.
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2007-06-25 23:03:03
On Sun, 24 Jun 2007 15:59:54 +0200 Ralf Baechle [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Fixed by including <linux/dma-mapping.h>: CC drivers/net/au1000_eth.o drivers/net/au1000_eth.c: In function 'au1000_probe': drivers/net/au1000_eth.c:661: warning: implicit declaration of function 'dma_alloc_noncoherent' drivers/net/au1000_eth.c:802: warning: implicit declaration of function 'dma_free_noncoherent' Signed-off-by: Ralf Baechle <redacted>diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c index c39ab80..c27cfce 100644 --- a/drivers/net/au1000_eth.c +++ b/drivers/net/au1000_eth.c@@ -34,7 +34,7 @@ * * */ - +#include <linux/dma-mapping.h> #include <linux/module.h> #include <linux/kernel.h> #include <linux/string.h>
That's more than a warning fix. On most platforms, dma_alloc_noncoherent() is a #define so the driver just won't link there. <looks> But the driver is mips-only, and MIPS uses a regular C function for dma_alloc_noncoherent(), so you got lucky. Still, I'd say this is for-2.6.22.