Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2
From: pradeep singh <hidden>
Date: 2007-06-25 05:46:56
From: pradeep singh <hidden>
Date: 2007-06-25 05:46:56
On 6/23/07, Andrew Morton [off-list ref] wrote:
quoted
On Thu, 21 Jun 2007 18:48:30 +0530 "pradeep singh" [off-list ref] wrote: Hi, My mistake. Resending after reformatting the patch by hand. Looks like gmail messes the plain text patches.That's still mangled so I typed it in again.
Sorry Andrew.
Please always include a full changlog with each version of a patch.
point noted down.
I do not know what this patch does - please provide a changelog. In this case it should tell us whether and how this null pointer deref is actually occuring and if so, why.
affirmative.
As well as a full description of the problem which it solves, a changelog should also describe _how_ it solved it, but that is sufficiently obvious in this case.
Thanks for the invaluable suggestion Andrew. Thanks a lot once again. ~pradeep
Thanks.
-- Pradeep