Thread (6 messages) flat view 6 messages, 3 authors, 2007-06-15

Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules

From: Michael Buesch <hidden>
Date: 2007-06-15 12:21:10
Also in: xen-devel

On Friday 15 June 2007 14:20:34 Keir Fraser wrote:
On 15/6/07 13:11, "Michael Buesch" [off-list ref] wrote:
quoted
quoted
No use of the following please:
If (foo) return 1; else return 0;
Is clearer as:
Return foo;
But it's not the same.
return !!foo;
would be the same. And yes, it does matter:
True in general, but not the cases I've seen in this patchset, where 'foo'
is a predicate.
Ok, if foo is a variable containing an error code, it's
better to return that error code. I assumed that foo is a
variable containing some value (counter or something).

-- 
Greetings Michael.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help