Re: [PATCH] cfg80211: fix signed macaddress in sysfs
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2007-06-04 11:41:09
Also in:
linux-wireless
On Mon, 2007-06-04 at 00:06 +0200, David Lamparter wrote:
Fix signedness mixup making mac addresses show up strangely (like 00:11:22:33:44:ffffffaa) in /sys/class/ieee80211/*/macaddress.
Huh, my mistake, patch looks good. Do we care for this in .22 still? Acked-by: Johannes Berg <johannes@sipsolutions.net>
quoted hunk
Signed-off-by: David Lamparter <redacted> --- net/wireless/sysfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/net/wireless/sysfs.c b/net/wireless/sysfs.c index 7844be4..374d16d 100644 --- a/net/wireless/sysfs.c +++ b/net/wireless/sysfs.c@@ -33,7 +33,7 @@ static ssize_t _show_permaddr(struct device *dev, struct device_attribute *attr, char *buf) { - char *addr = dev_to_rdev(dev)->wiphy.perm_addr; + unsigned char *addr = dev_to_rdev(dev)->wiphy.perm_addr; return sprintf(buf, "%.2x:%.2x:%.2x:%.2x:%.2x:%.2x\n", addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
This probably should also use MAC_FMT/MAC_ARG, hah. Oh well, I'll fix it up later. johannes
Attachments
- signature.asc [application/pgp-signature] 190 bytes